Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main_0.24] Cherry-picking PopupMenuController + iOS 17 changes #1940

Merged
merged 3 commits into from
Dec 5, 2023
Merged

[main_0.24] Cherry-picking PopupMenuController + iOS 17 changes #1940

merged 3 commits into from
Dec 5, 2023

Conversation

sophialee0416
Copy link
Contributor

@sophialee0416 sophialee0416 commented Dec 5, 2023 •
edited by microsoft-github-policy-service bot
Loading

Platforms Impacted

  • iOS
  • macOS

Description of changes

Cherry-picking the following:

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

mischreiber and others added 2 commits December 5, 2023 12:25
@mischreiber @sophialee0416
Make FluentUI be iOS 17 safe (microsoft#1935)
fbe7449 
* Make FluentUI be iOS 17 safe

* Fix whitespace

(cherry picked from commit d41a66c)
@sophialee0416
Fix popupmenu colors (microsoft#1937)
53325d7 
(cherry picked from commit 5b5ca0a)
@sophialee0416 sophialee0416 requested a review from a team as a code owner December 5, 2023 20:27
@sophialee0416 sophialee0416 changed the base branch from main to main_0.24 December 5, 2023 20:28
@sophialee0416
Copy link
Contributor Author

Waiting for #1938 to merge

@sophialee0416 sophialee0416 mentioned this pull request Dec 5, 2023
Merged
11 tasks
@sophialee0416 sophialee0416 merged commit 0539af1 into microsoft:main_0.24 Dec 5, 2023
6 checks passed
@sophialee0416 sophialee0416 deleted the sople/cherryPick branch July 15, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joannaquu joannaquu joannaquu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sophialee0416 @joannaquu @mischreiber